Simplify worker_memory calculation in get_total #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worker is a hash of { "worker" => 94, "worker2" => 95... }, we can call values
and sum instead of map + inject.
This also works when there is no worker:
{}.values.sum => 0
Benchmark.ips do |x|
x.report("current") { workers.map {|_, mem| mem }.inject(&:+) || 0 }
x.report(" after") { workers.values.sum }
x.compare!
end;
Warming up --------------------------------------
current 8.155k i/100ms
after 59.066k i/100ms
Calculating -------------------------------------
current 88.131k (± 5.8%) i/s - 440.370k in 5.015402s
after 739.807k (±31.1%) i/s - 3.367M in 5.091182s
Comparison:
after: 739807.1 i/s
current: 88130.6 i/s - 8.39x slower
JuanitoFatas
force-pushed
the
memory/workers
branch
from
33f68a2
to
603f8fd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I was playing with this and notice we could simplify the calculation of workers‘ memory a little bit. This also makes it a little bit faster 💨