Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping LETTERS - enhancement #1

Open
chris-english opened this issue Feb 29, 2024 · 1 comment
Open

Mapping LETTERS - enhancement #1

chris-english opened this issue Feb 29, 2024 · 1 comment

Comments

@chris-english
Copy link

(arrived here from your chronos post)

https://github.com/scumdogsteev/phonenumber/blob/master/R/letterToNumber.R
to bring to light numbers represented by letters perhaps with an else on
any(stringr::str_detect('1-800-FLOWERS', LETTERS))
[1] TRUE

I've made much much less headway on Rust and R, yet yesterday the US White House urged transition to memory safe base code, and one thinks Rust rather than Ruby. I'm a historian and code dabbler, but my history view says that nearly every problem in programming has been solved before...I'll go back to updating my Rust and try again.

@schochastics
Copy link
Owner

Could you be more specific in what you are asking for? the parse function does recognize numbers with letters already

dialrs::phone_parse("+1 1 800 FLOWERS",format = "International")
#> "+1 18003569377"

are you looking for something like this (not implemented atm)

dialrs::phone_has_letters("+1 1 800 FLOWERS)"
#> TRUE
dialrs::phone_has_letters("+1 1 800 123456)"
#> FALSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants