Modify _data to be protected instead of private to allow extending SwissQRBill #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Your change will be included in the next release. |
|
Would it be possible to trigger a release? We would love to use this in our production app as well. |
|
SwissQRBill v3.2.0 containing this change is now released on npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool and well maintained package!
We would like to use SwissQRBill to print multi-page bills with multiple different QR-bills.
For that purpose we want to extend PDF_, this however is currently not possible because _data is private.
Would it be possible to make it protected instead?
Merci!