Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different indicator for reception of text messages #388

Closed
wamserma opened this issue Apr 30, 2021 · 3 comments · Fixed by #390
Closed

Use different indicator for reception of text messages #388

wamserma opened this issue Apr 30, 2021 · 3 comments · Fixed by #390
Labels

Comments

@wamserma
Copy link
Contributor

Describe the bug

To Reproduce

For the sender:

  1. echo foo > text; croc send text
  2. croc send -t bar

In both cases the recipient gets Accept 'text' and the recipient cannot distinguish between these cases unless the transfer has been initiated.

Expected behaviour

In the text case, the recipient should see Accept text message. do distinguish from receiving a file, which is always quoted.

Version

croc version v9.1.0-35106d4

@wamserma wamserma added the bug label Apr 30, 2021
@schollz
Copy link
Owner

schollz commented Apr 30, 2021

This only occurs when you send a file named "text", correct?

Do you have any suggestions for a different indicator?

@wamserma
Copy link
Contributor Author

This only occurs when you send a file named "text", correct?

Do you have any suggestions for a different indicator?

In the simplest form, leave out the quotes, as proposed above. While this can still be overlooked, at least it can be distinguished from a quoted file name.

@schollz
Copy link
Owner

schollz commented Apr 30, 2021

Thanks, sorry I overlooked that in your issue. Sounds like a reasonable idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants