Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't style vertical lines between column groups #70

Closed
AdamPD opened this issue Oct 25, 2016 · 3 comments
Closed

Can't style vertical lines between column groups #70

AdamPD opened this issue Oct 25, 2016 · 3 comments

Comments

@AdamPD
Copy link

AdamPD commented Oct 25, 2016

Currently, we can't find any way to style vertical lines between column groups. We know that we can do it when you're using fixed column groups, but we simply want a vertical line through the entire table for each column groups (when none are fixed).

Expected Behavior

We'd like to be able to have a public style where we can add a nice border/vertical line through the edge of each column group to give a user clear grouping of columns. We don't want a vertical line for every single column - just the grouped ones.

Current Behavior

Currently, the only way is to use fixed column groups, which means you can only have "effectively" two column groups with the vertical line through them. We've looked at the CSS and there are no "overarching" cell group elements, nor are there any special CSS classes on the start/end columns in a group.

Possible Solution

The easiest solution would be to add a public CSS class to the start of every column group (e.g. public_fixedDataTableCell_cellFirstInGroup or something).

Context

Ideally, the user should see nice column groups in the table spanning the entire height. This helps our users analyse different parts of the table clearly.

@wcjordan
Copy link
Member

wcjordan commented Nov 2, 2016

Hey Adam, sorry I've left this hanging without responding. I'm looking into the issue, but our rendering of cell groups doesn't provide a great component for styling. I'm going to dig in a bit deeper and hopefully can find somewhere to add something. Once again sorry for the delay.

Also I'm going to link this to #60 to ensure we make this easier with longer term styling changes.

@wcjordan
Copy link
Member

Hey, I've put a PR for this up at #83. Could you check that branch out and see if it meets your needs?

@wcjordan
Copy link
Member

wcjordan commented Dec 5, 2016

I'm going to close this due to inactivity.

@wcjordan wcjordan closed this as completed Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants