Fix resizer line positioning #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepnschrodinger
added
bug
regression
| /** | ||
| * @type {number} Top position of ResizerKnow. It is passed to ResizerLine to render at appropriate position. | ||
| */ | ||
| top: 0, |
There was a problem hiding this comment.
Not needed anymore since the vertical offset of the resizer line is positioned relative to the table at 0px.
| @@ -26,7 +26,7 @@ | |||
| border-right-width: 1px; | |||
| box-sizing: border-box; | |||
| position: absolute; | |||
| z-index: 10; | |||
| z-index: 100; | |||
There was a problem hiding this comment.
This makes the resizer line go above the scrollbar UI.
Comment on lines
+163
to
+164
| FixedDataTableEventHelper.getCoordinatesFromEvent(ev).x - | ||
| ev.currentTarget |
There was a problem hiding this comment.
This positions it relative to the main table div.
|
LGTM |
AmanGupta2708
approved these changes
Dec 7, 2023
|
Released with v2.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes resizer line's positoning so that it works with cases where the main table is positioned/offset in a modal (see #707).
The main change here is that we no longer render the resizer line at
document.bodywithfixedpositioning.Instead, it's portalled to the top-level table element and given a
relativepositioning.This ensures that the resizer line has the same stacking context and positioning relative to the table (behavior in v1.2).
Motivation and Context
Fixes #707
How Has This Been Tested?
Tested with local examples.
Screenshots (if appropriate):
Before:
After:
Types of changes
Checklist: