Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize vertical bar public in header_ FixedDataTableColumnResizerLine_ Main positioning is not accurate #707

Closed
qlandroid opened this issue Nov 24, 2023 · 4 comments · Fixed by #709
Assignees
Labels

Comments

@qlandroid
Copy link

Resize vertical bar public in header_ FixedDataTableColumnResizerLine_ Main positioning is not accurate;
微信图片_20231124115929

@pradeepnschrodinger
Copy link
Collaborator

Hey, could you provide more details?
eg:

Version used:
Browser Name and version:
Operating System and version (desktop or mobile):
Link to your project:

Also the screenshot is blurry, so I'm not able to figure out what's exactly going wrong.

@pradeepnschrodinger
Copy link
Collaborator

Oh wait, I think I got the issue 🤞.

You appear to be using something like a "modal" dialog with the fixed data table rendered inside it.
The table is thus translated to a different position under a different z-index.
This somehow causes the resizer line to incorrectly render at a different position, and also get cut off by the modal.

This looks like an issue from FDT, we'll take a look at.

@pradeepnschrodinger
Copy link
Collaborator

@qlandroid, I've put a PR (see #709) to tackle some resizer line positioning issues.
This should get merged in a couple of days.

However, I'm not certain if this fixes the specific issue you're facing.
It would be nice if you can post more details as per this comment.

pradeepnschrodinger added a commit that referenced this issue Dec 7, 2023
The main change here is that we no longer render the resizer line at document.body with fixed positioning.

Instead, it's portalled to the top-level table element and given a relative positioning.
This ensures that the resizer line has the same stacking context and positioning relative to the table (behavior in v1.2).
@pradeepnschrodinger
Copy link
Collaborator

@qlandroid , The fix for this issue is released with v2.0.4.

I'm marking the issue as closed, but feel free to continue the discussion or reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants