Implemented filterable store decorator #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } from '../utils'; | ||
|
|
||
| export class FilterableStoreBehavior extends Behavior { | ||
| constructor(instance, {collection} = {}) { |
There was a problem hiding this comment.
It would be nice if for SortableStore, FilterableStore and PaginatableStore we could also configure the transformerWeight. Could easily be done by extracting transformerWeight from the config like we do with collection.
Doesnt have to be done with this PR though.
| describe('onFilterClear', () => { | ||
| it('When clearing a filter items should return to original state', () => { | ||
| behavior.onFilterChange('nameFilter', { | ||
| property: 'name', |
There was a problem hiding this comment.
This is still old style
tommyminds
added a commit
that referenced
this pull request
Oct 22, 2015
Implemented filterable store decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.