Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What change in API 29 #1179

Closed
mercadeoshop opened this issue Apr 15, 2020 · 8 comments
Closed

What change in API 29 #1179

mercadeoshop opened this issue Apr 15, 2020 · 8 comments

Comments

@mercadeoshop
Copy link

Hi, i use a custom app of ICS Openvpn from codecanyon, but for what i see if i change the target sdk to 29 stop working on android 10 devices. Can you tell why is that or what change it?

@schwabe schwabe closed this as completed Apr 15, 2020
@schwabe
Copy link
Owner

schwabe commented Apr 15, 2020

This bug tracker only deals with this app and this app has no problem with Target SDK 29.

@mehroz1
Copy link

mehroz1 commented Oct 15, 2020

Comment Removed. See reason below

Instead of band aid fixing an old version of the software using a library that you didn't built yourself, you should just use the latest version of the upstream software. As VPN software is security sensitive, there is no excuse in using old versions.

@schwabe
Copy link
Owner

schwabe commented Oct 16, 2020

You should never use the libraries from other packages, the repository includes everything to build it.

@mehroz1
Copy link

mehroz1 commented Oct 16, 2020

You should never use the libraries from other packages, the repository includes everything to build it.

Yes you are right no arguments there.

@mercadeoshop
Copy link
Author

Comment Removed. See reason below

Instead of band aid fixing an old version of the software using a library that you didn't built yourself, you should just use the latest version of the upstream software. As VPN software is security sensitive, there is no excuse in using old versions.

Thank you very much for your help, was very helpfull, there is a way i can contact you?

@mehroz1
Copy link

mehroz1 commented Nov 13, 2020

@schwabe whatever you are trying to do is not right. You are removing comment instead of moderating it. Why so much secrecy?

I was just answering the question why its failing on android and instead of making the comment compliant to your project you chose to entirely remove it.

You are either clearly trying to hide something from public or you do not want anyone to implement to ics-openvpn except for official OpenVPN Android client or your own on playstore (both based on this repo). So what is it? What is it you are hiding from public? or you are using cheap tactics to earn some money for disclosing these issues. Either way you are hiding something.

@mehroz1
Copy link

mehroz1 commented Nov 13, 2020

Comment Removed. See reason below
Instead of band aid fixing an old version of the software using a library that you didn't built yourself, you should just use the latest version of the upstream software. As VPN software is security sensitive, there is no excuse in using old versions.

Thank you very much for your help, was very helpfull, there is a way i can contact you?

You can contact me on my github fork of EasyVPN.

@schwabe
Copy link
Owner

schwabe commented Nov 13, 2020

@mehroz1 I am not hiding something. I don't want to bad practice being spread on my github repository. That is why I removed that comment that promoted bad practice. And the official OpenVPN Connect is NOT based on this repo.

What I clearly don't want is insecure variants of my app floating around, ESPECIALLY not from people that do not respect the license and contribute nothing back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants