Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(microdrop): actuation errors reference electrode IDs not channel numbers #264

Open
ryanfobel opened this issue Nov 1, 2018 · 2 comments

Comments

@ryanfobel
Copy link
Contributor

Currently, when there is an actuation error, the error dialog reports electrode IDs. This is not very useful to the user as it is difficult to map electrode IDs to the device view (electrode IDs are only shown to the user when hovering over a specific electrode).

image

I suggest that these error dialogs should show channel IDs, since these can be displayed on the device view using the "channel_labels" layer.

@cfobel
Copy link
Contributor

cfobel commented Nov 1, 2018

In my mind, electrodes are what are being actuated (specific to the DMF chip, but not specific to the DropBot; e.g., the DropBot plugin may not even be installed) and channels are a DropBot implementation detail. @ryanfobel would you agree with this?1

That said, since we are only really concerned with the DropBot, I certainly agree that the electrode IDs are not particularly useful. However, this could be addressed by simply changing the id attribute of each electrode path in the SVG (i.e., the electrode IDs) to match the respective DropBot channel number. @ryanfobel what do you think?


1. In MicroDrop, all actuation-related code outside of the DropBot plugin operates on electrode IDs. The DropBot plugin then maps requests for actuation of electrodes to the corresponding hardware channels.

@cfobel
Copy link
Contributor

cfobel commented Jan 25, 2019

@ryanfobel and@cfobel decided to postpone matching of electrode IDs to DropBot channels until we finalize the new 120-channel chip layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants