Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification version is invalid #15

Open
hinerm opened this issue Mar 25, 2015 · 2 comments
Open

Specification version is invalid #15

hinerm opened this issue Mar 25, 2015 · 2 comments

Comments

@hinerm
Copy link
Member

hinerm commented Mar 25, 2015

We are currently always set specificationVersion = implementationVersion = POM version. As specificationVersion is decimal-numeric-only, we are setting invalid versions any time our POM version has alpha characters (e.g. "beta-X", "rc-Y").

@hinerm hinerm added the bug label Mar 25, 2015
@hinerm hinerm added this to the unscheduled milestone Mar 25, 2015
@ctrueden
Copy link
Member

ctrueden commented May 5, 2017

Confirmed that this is still an issue as of this writing. The addDefaultImplementationEntries and addDefaultSpecificationEntries options set in the pom-scijava-base parent cause the respective versions of the manifest to match the Maven version, even if the Maven version does not conform to the rules for Specification-Version. It may be a bug in Maven, because according to the docs, the Specification-Version is supposed to be set to: ${project.artifact.selectedVersion.majorVersion}.${project.artifact.selectedVersion.minorVersion}. But I checked, and it is not.

@ctrueden
Copy link
Member

Note that as of scijava/pom-scijava-base@0380c33a, we do compute a sanitized x.y.z version string that could be used for the specification version of the JAR manifest. I am hesitant to change it, though, until we read up a bit more on the ramifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants