Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated save-pixels signature to match get-pixels. Fixes #6 #7

Merged

Conversation

twolfson
Copy link
Contributor

As discussed in #6, it would be ideal to have consistent signatures between get-pixels and save-pixels. To keep consistency with Canvas, we are using [width, height, channels] for our ndarray's. In this PR:

  • Upgrade to get-pixels@3.0.1 to pickup latest signature
  • Updated README.md with new ndarray signature
  • Updated save-pixels.js to work with new shape

@twolfson twolfson mentioned this pull request Oct 10, 2014
@mikolalysenko mikolalysenko merged commit 88e0b41 into scijs:master Oct 18, 2014
@mikolalysenko
Copy link
Member

Thanks!

@twolfson twolfson deleted the dev/upgrade.get-pixels.sqwished branch October 20, 2014 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants