Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete XML/ROOT Import to all supported modifieres #115

Closed
lukasheinrich opened this issue Apr 14, 2018 · 1 comment
Closed

Complete XML/ROOT Import to all supported modifieres #115

lukasheinrich opened this issue Apr 14, 2018 · 1 comment
Projects
pyhf development

Comments

@lukasheinrich
Copy link
Contributor

Description

The XML/ROOT import code currently only support OverallSys and NormFactor but by now we support more modifiers natively in pyhf. We should thus extend this code

https://github.com/diana-hep/pyhf/blob/master/pyhf/readxml.py
@lukasheinrich lukasheinrich mentioned this issue Apr 16, 2018
Closed
@lukasheinrich lukasheinrich changed the title Complete Import to all supported modifieres Complete XML/ROOT Import to all supported modifieres Apr 16, 2018
@matthewfeickert matthewfeickert added this to To do in pyhf development via automation Apr 16, 2018
@kratsg
Copy link
Contributor

kratsg commented Aug 20, 2018

I believe this is done by now, as of #146 and #154.

@kratsg kratsg moved this from To do to Done in pyhf development Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pyhf development
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratsg @lukasheinrich