Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-release support to publish workflow #1907

Closed
matthewfeickert opened this issue Jun 29, 2022 · 2 comments · Fixed by #1968
Closed

Add pre-release support to publish workflow #1907

matthewfeickert opened this issue Jun 29, 2022 · 2 comments · Fixed by #1968
Assignees
Labels
CI CI systems, GitHub Actions packaging setup.py, setup.cfg, pyproject.toml, and friends

Comments

@matthewfeickert
Copy link
Member

Creating the GitHub pre-release v0.7.0rc1 should have triggered the publish to PyPI workflow, but it didn't. I don't think that there is a pre_release github.event_name

- name: Publish distribution 📦 to PyPI
if: github.event_name == 'release' && github.event.action == 'published' && github.repository == 'scikit-hep/pyhf'

so we'll need to figure out how release candidate pre-releases can get integrated in.

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions packaging setup.py, setup.cfg, pyproject.toml, and friends labels Jun 29, 2022
@matthewfeickert matthewfeickert self-assigned this Jun 29, 2022
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Jun 30, 2022

So seems that I need to learn the github.event API better as there is apparently a github.event.release.prerelease. So I now don't know how github.event_name and github.event.release's attributes differ.

edit
Under https://docs.github.com/en/rest/releases/releases#create-a-release there is

prerelease boolean
true to identify the release as a prerelease. false to identify the release as a full release.
Default: false

Thought this seems to imply that a prerelease is not a published event.action(?).

@matthewfeickert
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions packaging setup.py, setup.cfg, pyproject.toml, and friends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant