Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minimum supported dependencies workflow to allow for UserWarnings to be caught #2016

Closed
matthewfeickert opened this issue Sep 20, 2022 · 1 comment
Labels
fix A bug fix tests pytest

Comments

@matthewfeickert
Copy link
Member

This will require an update to

- name: Test with pytest
run: |
# Override the ini option for filterwarnings with an empty list to disable error on filterwarnings
# as testing for oldest releases that work with latest API, not the oldest releases that are warning
# free. Though still show warnings by setting warning control to 'default'.
export PYTHONWARNINGS='default'
# Run on tests/ to skip doctests of src given examples are for latest APIs
pytest --override-ini filterwarnings= --ignore tests/benchmarks/ --ignore tests/contrib --ignore tests/test_notebooks.py tests/

given that the current workflow ignores all warnings, and so this fails for the Minimum supported dependencies workflow. Do this in another PR.

$ PYTHONWARNINGS='default' pytest tests/test_infer.py

works, but I don't think that will work for the entire test suite.

Originally posted by @matthewfeickert in #1274 (comment)

@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Sep 20, 2022
@matthewfeickert
Copy link
Member Author

Just get rid of the UserWarning instead #1274 (comment) as they aren't very useful in reality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

No branches or pull requests

1 participant