Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: add "type: histfactory" to likelihood JSON #740

Open
lukasheinrich opened this issue Jan 17, 2020 · 2 comments
Open

spec: add "type: histfactory" to likelihood JSON #740

lukasheinrich opened this issue Jan 17, 2020 · 2 comments
Labels
schema and spec JSON schema

Comments

@lukasheinrich
Copy link
Contributor

lukasheinrich commented Jan 17, 2020

Description

HepData may start hosting different types of likelihoods in different formats, it might be nice to be explicit / self-explanatory what type of likelihood one is looking at

{
"version": "1.0.0",
"type": "histfactory",
...
}

would be cool.. maybe even we can make this be JSON-LD at some point?

@lukasheinrich lukasheinrich added the schema and spec JSON schema label Jan 17, 2020
@matthewfeickert
Copy link
Member

HepData may start hosting different types of likelihoods in different formats

I noticed that in the drat report from the LHC Re-Interpretation Forum Report draft that was emailed around today (also nice job on Section 2.4 @lukasheinrich). 🙂

it might be nice to be explicit / self-explanatory what type of likelihood one is looking at

{
"version": "1.0.0",
"type": "histfactory",
...
}

would be cool.. maybe even we can make this be JSON-LD at some point?

This would be really cool! Correct me if I'm wrong, but this could get added in right now and then the next time we bump the JSON schema version number we can make it a requirement for that schema version(?).

@kratsg
Copy link
Contributor

kratsg commented Jan 24, 2020

This would be really cool! Correct me if I'm wrong, but this could get added in right now and then the next time we bump the JSON schema version number we can make it a requirement for that schema version(?).

Yes. Add a 2.0.0, copy over the files -- make the change, bump the version, keep it at 1.0.0 in the utils and we should be ok for now. Likely, we'll need to make our tools grab the version from the spec and use that as the default if the user doesn't override it. Then we don't need to maintain a default in our code and just handle the translation by version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema and spec JSON schema
Projects
None yet
Development

No branches or pull requests

3 participants