Merge pull request #1436 from ericdill/save-buttons-fix

TST: Barn-door testing of SaveButtons clicks
scikit-image · Mar 19, 2015 · e91dcba · e91dcba
2 parents 6051ff2 + 8af4373
commit e91dcba
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/skimage/viewer/tests/test_widgets.py b/skimage/viewer/tests/test_widgets.py
@@ -101,6 +101,11 @@ def test_save_buttons():
     timer = QtCore.QTimer()
     timer.singleShot(100, QtGui.QApplication.quit)
 
+    # exercise the button clicks
+    sv.save_stack.click()
+    sv.save_file.click()
+
+    # call the save functions directly
     sv.save_to_stack()
     with expected_warnings(['precision loss']):
         sv.save_to_file(filename)

diff --git a/skimage/viewer/widgets/history.py b/skimage/viewer/widgets/history.py
@@ -80,9 +80,9 @@ def save_to_stack(self):
         notify(msg)
 
     def save_to_file(self, filename=None):
-        if filename is None:
+        if not filename:
             filename = dialogs.save_file_dialog()
-        if filename is None:
+        if not filename:
             return
         image = self.plugin.filtered_image
         if image.dtype == np.bool: