TST: Barn-door testing of SaveButtons clicks #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ def save_to_stack(self): | |||
| notify(msg) | |||
|
|
|||
| def save_to_file(self, filename=None): | |||
| if filename is None: | |||
| if not filename: | |||
| filename = dialogs.save_file_dialog() | |||
| if filename is None: | |||
There was a problem hiding this comment.
This should be changed as well.
The canny_simple.py demo in viewer_examples/plugins has a save button that raises an AttributeError in PIL because the button click is passing 'False' to the SaveButtons.save_to_file function when it expects a filename or None.
|
Great, thanks @ericdill! |
blink1073
added a commit
that referenced
this pull request
Mar 19, 2015
TST: Barn-door testing of SaveButtons clicks
|
Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening up
canny_simple.pyand clicking thefilebutton produces the following stacktrace that this PR fixes.The canny_simple.py demo in viewer_examples/plugins has a save that raises an AttributeError in PIL because the button is passing 'False' to the
SaveButtons.save_to_filefunction which expects a filename or None. TheFalsecomes from theclickedsignal on the Qt PushButton object which is emitting a boolean value in its signal to state if the button ischecked. This boolean value is being passed to thefilenameinput parameter toSaveButtons.save_file()which is causing havoc in pil.