Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve all warning messages #3140

Open
jni opened this issue Jun 1, 2018 · 4 comments
Open

Improve all warning messages #3140

jni opened this issue Jun 1, 2018 · 4 comments
Labels
📄 type: Documentation Updates, fixes and additions to documentation 🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@jni
Copy link
Member

jni commented Jun 1, 2018

Our warnings are pretty noisy and usually sends users on a wild Google search to find how to fix their problem. Instead we should provide informative messages everywhere that include links to relevant documentation. @stefanv suggests React.js as a good model for this.

@soupault soupault added 📄 type: Documentation Updates, fixes and additions to documentation 🔧 type: Maintenance Refactoring and maintenance of internals labels Jun 2, 2018
@sciunto sciunto added this to the 1.0 milestone Aug 17, 2019
@stefanv
Copy link
Member

stefanv commented Oct 11, 2022

The idea here was that we would link, e.g., deprecation messages to a page that explains the issue in more detail. I think it's a good idea, but it requires infrastructure that we haven't built yet.

If I had to guess how we'd build this: add a directory of pages to the docs, pages are numbered, and links given in docs become something like https://skimage.org/ref/192-breaking-api.html and then have Netlify redirect /ref/* to https://scikit-image.org/docs/dev/*.

(If we're not hosting on Netlify yet, that's probably a good next step.)

@lagru
Copy link
Member

lagru commented Apr 11, 2023

As a user I like the idea, as a maintainer, I don't. We are already struggling to keep our TODO.txt and narrative documentation up to date. Even worse than verbose warning messages are messages that point to outdated or non-existent resources. If there were a way to test this or make this more reliable somehow, I wouldn't mind this. For now I'm -0.5 because I think the added maintenance burden is not worth it. Always open to arguments of course. 😉

@lagru
Copy link
Member

lagru commented Apr 11, 2023

Also, I'm curious what kind of warnings you'd consider noisy as I haven't really felt that pain yet.

@lagru lagru removed this from the 0.21 milestone Apr 11, 2023
@stefanv
Copy link
Member

stefanv commented Apr 11, 2023

A good start would be to simply write longer messages that provide better transition instructions to the user.

Think about this for the skimage v2 transition, though: do you prefer to maintain very long messages and re-use those in different places, or could it be easier to keep webpages, with proper markdown etc., updated and link to them? Genuine question! We shouldn't build mechanisms we don't use.

We'd keep it lightweight, though; e.g. a directory of markdown files that get published automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

5 participants