.format() in (legacy) code could be converted to f-strings.

[mkcor]

Description

To address this issue, a new contributor could start with a recursive grep for \.format\( on a subpackage of interest to them (or on the entire package). Replacing instances of .format() with f-strings can be a good pretext to explore the codebase.

Reference: https://www.python.org/dev/peps/pep-0498/

[alex-jw-brooks]

Hello! May I work on this issue?

[that1solodev]

I'd like to work on this

[mkcor]

For sure! @alex-jw-brooks could do it for the filters subpackage and @Xyno18 for the segmentation subpackage: How does that sound?

[alex-jw-brooks]

That sounds great, thanks!

[that1solodev]

Sounds great. I'm on it

[Larkinnjm1]

Hey folks looking to contribute to a first issue on this repo can I look to work on this issue for other sub modules such as restoration and registration?

[mkcor]

Hi @Larkinnjm1,

can I look to work on this issue for other sub modules such as restoration and registration?

Sure, please go for it!

[MariosAchilias]

Hello, i'd also like to contribute, can I work on this for the color, exposure, transform and util modules?

[mkcor]

Hi @MariosAchilias,

Hello, i'd also like to contribute, can I work on this for the color, exposure, transform and util modules?

Ok!

[Larkinnjm1]

Hi @Larkinnjm1,

can I look to work on this issue for other sub modules such as restoration and registration?

Sure, please go for it!

Cool great on it!

[jstriebel]

Just a recommendation: pyupgrade is a tool which can automatically apply new python-features on code, such as converting "".format() calls to f-strings:
https://github.com/asottile/pyupgrade#f-strings

It might also do too many other conversions you don't want in the code-base, not sure about that, just a suggestion :-)

[mkcor]

Hi @jstriebel,

It might also do too many other conversions you don't want in the code-base, not sure about that, just a suggestion :-)

Exactly! But, it might be worth considering each pyupgrade item, to decide whether to include it or not. Thanks for the suggestion!

[mkcor]

To track this issue more finely and eventually close it, I'm listing all the skimage subpackages below (check the box once the corresponding PR is merged):

• color (Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508)
• data
• draw
• exposure (Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508)
• external
• feature
• filters (Replacing filters .format() calls with f-strings #5478)
• future
• graph
• io
• measure
• metrics
• morphology
• registration (.format() coverted to f-strings in registration & restoration subpackage #5510)
• restoration (.format() coverted to f-strings in registration & restoration subpackage #5510)
• scripts
• segmentation (.format() coverted to f-strings in segmentation subpackage #5479)
• _share
• transform (Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508)
• util (Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508)
• viewer

[ovynnej]

Hello @mkcor! I'm not super experienced, so I just wanted to check -- should this issue be closed? Running grep -r ".format(" . on the package returns only these instances, which are not relevant to the issue:

./_shared/utils.py: warnings.warn(self.warning_msg.format(
./_shared/utils.py: warnings.warn(warning_msg.format(func_name=func.name),
./_shared/utils.py: warnings.warn(self.warning_msg.format(

Thank you!

[grlee77]

Thanks for the reminder, @ovynnej. Indeed, we had several contributors in July/August and I think all of these have been addressed.