-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508
Conversation
Hello @MariosAchilias! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-12 12:07:02 UTC |
I made the suggested changes. Thank you for the review. Is there anything else I should change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but it looks like a couple files in these modules were missed (found by running grep -r ".format("
in the skimage folder):
skimage/transform/_warps.py
skimage/color/tests/test_colorconv.py
Can you please update those two here as well? Thanks
Co-authored-by: Gregory R. Lee <grlee77@gmail.com>
@grlee77 I can't find any instance of I tried running |
Indeed, my apologies. I had not realized I ran this search on an outdated branch! This is good to merge |
Thanks @MariosAchilias! |
Description
Partially addresses #5474Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.