Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strings with .format() calls to f-strings in color, exposure, transform, and util subpackages #5508

Merged
merged 7 commits into from
Aug 12, 2021

Conversation

MariosAchilias
Copy link
Contributor

Description

Partially addresses #5474

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

pep8speaks commented Aug 10, 2021

Hello @MariosAchilias! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-12 12:07:02 UTC

skimage/color/colorconv.py Outdated Show resolved Hide resolved
skimage/transform/radon_transform.py Outdated Show resolved Hide resolved
skimage/util/dtype.py Outdated Show resolved Hide resolved
skimage/util/dtype.py Outdated Show resolved Hide resolved
@MariosAchilias
Copy link
Contributor Author

I made the suggested changes. Thank you for the review.

Is there anything else I should change?

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but it looks like a couple files in these modules were missed (found by running grep -r ".format(" in the skimage folder):
skimage/transform/_warps.py
skimage/color/tests/test_colorconv.py

Can you please update those two here as well? Thanks

skimage/util/dtype.py Outdated Show resolved Hide resolved
Co-authored-by: Gregory R. Lee <grlee77@gmail.com>
@MariosAchilias
Copy link
Contributor Author

MariosAchilias commented Aug 12, 2021

@grlee77 I can't find any instance of .format( in _warps.py and test_colorconv.py.

I tried running grep -r ".format(" and it doesn't show any file in those modules.

@grlee77
Copy link
Contributor

grlee77 commented Aug 12, 2021

I tried running grep -r ".format(" and it doesn't show any file in those modules.

Indeed, my apologies. I had not realized I ran this search on an outdated branch! This is good to merge

@grlee77 grlee77 merged commit 3ad3641 into scikit-image:main Aug 12, 2021
@grlee77
Copy link
Contributor

grlee77 commented Aug 12, 2021

Thanks @MariosAchilias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants