-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wavelet denoising filters #602
Comments
Hi @thearn, I never used wavelet but I'm interested in it. Do you have references? (pseudo-code or implementation in other languages is also appreciated). Scipy has several functions about wavelets, something is missing in it? I need more insights but maybe I can help. |
Here's an example of how to use pywavelets to do such filtering: https://github.com/stefanv/supreme/blob/master/supreme/noise/wavelet.py Perhaps that can serve as a starting point. |
@stefanv : Since your code is under GPL, it is not compatible with skimage's license. So, I need to officially ask you the permission to re-use here :-) |
Ah, before I saw the light. This is now fixed: https://github.com/stefanv/supreme/blob/master/doc/LICENSE.txt |
Sorry for raising the question then disappearing! I have a bit of free time now, so I can start working on this as well. I don't know if @stefanv has pull requested anything yet, but I've written quite a bit of python code for wavelet filtering while I was in grad school. |
@thearn I copy paste the email I sent to the mailing list few days ago. Thanks for your help. Dear skimagers, With Ralf, we initiated a "friendly" fork of pywavelet for a future If some of you used pywavelet before, we would be grateful to you if you Thanks! -------- Message original -------- Hi all, nigma/pywt#7 contains a large refactoring of
This set of changes is supposed to be fully backwards compatible. They While we've kept full backwards compatibility so far, we've also Cheers, |
@rgommers Sorry, just saw the thread about this as a potential project for GSoC on the scipy mailing list. |
@stefanv the integration is not a whole project, more like a few days of work. I'm just lacking the bandwidth at the moment. The main part of the GSoC would be adding new features, and things like a more complete tutorial maybe. The whole refactoring is done, so the code is in OK shape to be integrated now. |
@stefanv I'm working on an integration in scikit-image we can keep until an version of scipy integrating this feature is well spread on major OS/distrubutions. Thanks for the ping. |
@stefanv : Is this the thread you are referring to in your last comment(http://thread.gmane.org/gmane.comp.python.scientific.devel/18202/focus=18255)? |
@stefanv : thanks, I limited my search to scipy-dev list. @rgommers : I am yet to go through your major refactor PR(nigma/pywt#7) for pywt, but I guess after the integration of pywt with your refactor into scipy.signal, @thearn's PR(#760) can be merged in skimage without many changes? |
@ankit-maverick I didn't review that PR but I think so. Besides the minor issue that scikit-image should work with older scipy versions, so it should ship a private copy of what goes into scipy for a few releases. My PR should fix the Python 3.x issue and not have broken backwards compat (so far). We may rethink some API decisions before merging into scipy though. |
There is also a possible issue about scipy.integrate.cumtrapz/ (see https://github.com/rgommers/pywt/issues/7) we should look at. The main problem I had was with travis :/ I do not remember the details. |
Closed via #1833. More PRs to come occasionally. |
Discrete wavelet transforms are popular tools for denoising digital images and (other types of signals). Implementation of a few image filtering functions would be great, perhaps by letting pywavelets do the heavily lifting of the forward & inverse wavelet transformations.
The text was updated successfully, but these errors were encountered: