Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx 4.3.0 broke documentation generation; unpin when resolved #6030

Closed
hmaarrfk opened this issue Nov 11, 2021 · 2 comments · Fixed by #6034
Closed

Sphinx 4.3.0 broke documentation generation; unpin when resolved #6030

hmaarrfk opened this issue Nov 11, 2021 · 2 comments · Fixed by #6034
Labels
🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@hmaarrfk
Copy link
Member

Description

It seems that Sphinx 4.3.0 broke documentation generation. We should unpin when we get to the bottom of it.

#6029
grlee77 pushed a commit that referenced this issue Nov 11, 2021
@jni @hmaarrfk
Pin sphinx to <4.3 (#6029)
823fe10 
* Pin sphinx to <4.3

The recent 4.3 release broke our documentation builds (see gh-6030). Pin until we can resolve the issue.

Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@rfezzani
Copy link
Member

Fixed by #6029, Thank you!

@jni
Copy link
Member

jni commented Nov 15, 2021

@rfezzani you misunderstood @hmaarrfk, this issue is to remind us to unpin once we can fix this properly. It turns out that we can: sphinx-gallery 0.10.1 fixes things. We can close this issue once we unpin.

@jni jni reopened this Nov 15, 2021
@jni jni changed the title Sphinx 4.3.0 broke documetntation generation. Sphinx 4.3.0 broke documentation generation; unpin when resolved Nov 15, 2021
hmaarrfk added a commit to hmaarrfk/scikit-image that referenced this issue Nov 15, 2021
@hmaarrfk
Update sphinx gallery pin, Gloases scikit-image#6030
2ed638b
@hmaarrfk hmaarrfk mentioned this issue Nov 15, 2021
Merged
hmaarrfk added a commit to hmaarrfk/scikit-image that referenced this issue Nov 15, 2021
@hmaarrfk
Update sphinx gallery pin, Closes scikit-image#6030
3d9a609
@rfezzani rfezzani added the 🔧 type: Maintenance Refactoring and maintenance of internals label Nov 15, 2021
hmaarrfk added a commit to hmaarrfk/scikit-image that referenced this issue Nov 15, 2021
@hmaarrfk
Update sphinx gallery pin, Closes scikit-image#6030
df0d811
@grlee77 grlee77 mentioned this issue Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sphinx gallery pin hmaarrfk/scikit-image
3 participants
@hmaarrfk @jni @rfezzani