Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx to <4.3 #6029

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Pin sphinx to <4.3 #6029

merged 3 commits into from
Nov 11, 2021

Conversation

jni
Copy link
Member

@jni jni commented Nov 11, 2021

Description

A new version of sphinx was released today, breaking our doc builds, example:

https://github.com/scikit-image/scikit-image/runs/4168761105?check_suite_focus=true#step:5:2721

Error reads:

Extension error (sphinx_gallery.docs_resolv):
Handler <function embed_code_links at 0x7f4faec58af0> for event 'build-finished' threw an exception (exception: list indices must be integers or slices, not str)

I propose we pin sphinx until we can get to the bottom of this, since @grlee77 and I are working on the 0.19 release and we don't want this issue to hold it up.

@jni
Copy link
Member Author

jni commented Nov 11, 2021

Thanks @hmaarrfk, good changes. 😃

@hmaarrfk
Copy link
Member

squash and merge? Sorry i've been getting really bad habbits of using Github's online interface.

@grlee77 grlee77 merged commit 823fe10 into scikit-image:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants