-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP NEW histogram backprojection #3590
base: main
Are you sure you want to change the base?
Conversation
Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-01-15 06:18:06 UTC |
f4232f6
to
54cdfbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sciunto looking good! A few PEP8 issues (e.g. camelCase). Let us know when you think the WIP can come down and we can do a full review.
This is not ready yet imho. I just fixed something that crossed a grep on my repository. :) |
@sciunto what else did you want to do for this PR? I noticed that some variable names (B, R...) did not correspond to our conventions of using meaningful names. But apart from that it looks good. Happy to take over with your guidance, if you prefer. |
@emmanuelle I do not like the way the color detection is done. I believe that we consider this as "magic" (ie guess from dimensions). Instead, kwarg is the function's signature would be better. Also, I do not like that images are forced to be with a 8 bits precision. This must be generalized as well. I agree also for some cleanup on the variable names. Unitests are missing as well. Still a significant effort to do, if you would like to help, I'll be happy of it :) |
Description
This PR replaces and enhances #979
TODO list
Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
[For detailed information on these and other aspects see scikit-image contribution guidelines]
References
[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]
For reviewers
(Don't remove the checklist below.)
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x