Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tools: remove pyproject.toml #3688

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

hmaarrfk
Copy link
Member

fixes: #3576
fixes: #3685

cc: @jni @stefanv

Description

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@jni jni merged commit 89b7702 into scikit-image:master Jan 29, 2019
@hmaarrfk hmaarrfk deleted the remove_pyproject.toml branch January 29, 2019 13:49
@hmaarrfk
Copy link
Member Author

@soupault thanks for that tiny fix.

@hmaarrfk hmaarrfk changed the title remove pyproject.toml Build tools: remove pyproject.toml Mar 4, 2019
@hmaarrfk
Copy link
Member Author

Even more reasons to get ride of this.

ERROR: Error installing 'file:///home/mark2/git/scikit-image': editable mode is not supported for pyproject.toml-style projects. pip is processing this project as pyproject.toml-style because it has a pyproject.toml file. Since the project has a setup.py and the pyproject.toml has no "build-backend" key for the "build_system" value, you may pass --no-use-pep517 to opt out of pyproject.toml-style processing. See PEP 517 for details on pyproject.toml-style projects.

@hmaarrfk
Copy link
Member Author

@meeseeksdev backport to v0.14.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 17, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v0.14.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 89b770213692734a228264c1cb00875c68f56b91
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #3688: Build tools: remove pyproject.toml'
  1. Push to a named branch :
git push YOURFORK v0.14.x:auto-backport-of-pr-3688-on-v0.14.x
  1. Create a PR against branch v0.14.x, I would have named this PR:

"Backport PR #3688 on branch v0.14.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app bot added the Still Needs Manual Backport MrMeeseeks-managed label label May 17, 2019
hmaarrfk added a commit to hmaarrfk/scikit-image that referenced this pull request May 17, 2019
hmaarrfk added a commit that referenced this pull request May 17, 2019
@stefanv stefanv mentioned this pull request Nov 20, 2019
2 tasks
@grlee77 grlee77 mentioned this pull request Aug 15, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Still Needs Manual Backport MrMeeseeks-managed label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named 'skimage' when pip install scikit-image pyproject.toml whoes
4 participants