-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: doc of ridge functions #3933
Conversation
Thanks @sciunto ! The contrast of frangi is flattened because the higher values are at the border of the image, could you please increase the contrast (eg setting vmax) for this filter, since the result is quite good but it doesn't show here. |
We could also have more explanations about the differences between the different filters, but this can come in another PR because this PR is already an improvement. |
Do you think it is better to set a vmax for a particular case or crop all images of 4 pixels on each edge and add a note saying that Frangi leads to an edge effect removed in this example? PS: I'm discovering these filters and I'm not familiar at all with these algorithms. |
I'm confused — doesn't matplotlib automatically stretch the contrast for each image? |
Oh, sorry, misread @emmanuelle's comment. Hmmm. I'm not sure what the best answer is here. @sciunto go with whatever you think is prettiest I reckon. =) |
@sciunto I would stretch the contrast for this particular case and explain in the text that Frangi filter does this special thing at the border (which will be visible because these pixels will be saturated). But I also leave it to your personal taste, the important thing is that this subplot is not pitch black and users think frangi is worthless. |
Looks great, thanks @sciunto!!! |
* Replace the page image by vessels from retina * Add see also section to ridge functions * Add crop on Meijering and Frangi for rendering purpose
Description
This PR aims at improving the doc of #3515 as these functions are designed for processing on vessels, I changed the image for a crop of retina. I added see also sections as well.
Cc @DavidBreuer
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x