Add kwarg source_range to cumulative_distribution and equalize_hist #4056
Conversation
Co-Authored-By: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
Co-Authored-By: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
|
Absolutely, it's done. |
skimage/exposure/exposure.py
Outdated
| Number of bins used to calculate histogram. This value is ignored for | ||
| integer arrays, for which each integer is its own bin. | ||
| source_range : string, optional | ||
| 'image' (default) determines the range from the input image. |
There was a problem hiding this comment.
| 'image' (default) determines the range from the input image. | |
| 'image' (default) determines the range from minimum and maximum value of the input image. |
is this true?
There was a problem hiding this comment.
Yes, it's true, but not PEP8 compliant. =P
There was a problem hiding this comment.
I'm advocating to have this option set to 'source' by default. Although 'image' can be useful, it is not the most natural option to me. Especially, once you want to compare histograms, different ranges do not help. But, this is another story.
There was a problem hiding this comment.
@hmaarrfk Added and modified elsewhere also.
|
It doesn't seem related to this PR, but the travis failures look pretty serious! =\ |
|
I think those failures are because a bad version of qt is being pulled in. I really hate QT testing. Just look at how long Vispy has been trying to release their package, they are constantly stuck chasing changes in QT bugs |
|
Doesn't this need an easy test? |
Description
Xref #4054
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x