-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn single backquotes to double backquotes in filters #4127
Conversation
Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-09-01 10:24:45 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sciunto Since warning and error messages are not rendered, I suggest to keep there the previous versions. Otherwise, this is a clear improvement, 👍 .
|
||
Parameters | ||
---------- | ||
image: ndarray | ||
image : ndarray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these new spaces a thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix to match the convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
people just make up standards. I guess it does follow the numpydoc documentation
https://numpydoc.readthedocs.io/en/latest/format.html#docstring-standard
but I would have thought that there should be no space, like a python dictionary.
Description
See #4117
I applied a regexp and checked the diff. So far, it's applied only on the filters submodule.
I would like to have your feedback first.
I think it is worth it: better documentation, less "bad" examples for future contributions.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x