Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of util.apply_parallel in tutorial_parallelization.rst. #4214

Closed
wants to merge 1 commit into from
Closed

Usage of util.apply_parallel in tutorial_parallelization.rst. #4214

wants to merge 1 commit into from

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Oct 7, 2019

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@sciunto sciunto changed the title Mentioned in tutorial_parallelization.rst. Usage of util.apply_parallel in tutorial_parallelization.rst. Oct 10, 2019
@soupault soupault added the 📄 type: Documentation Updates, fixes and additions to documentation label Oct 10, 2019
soupault
soupault requested changes Oct 18, 2019
View reviewed changes
doc/source/user_guide/tutorial_parallelization.rst
from skimage.util.apply_parallel import apply_parallel
apply_parallel(threshold_local, a, chunks=(6, 6), depth=5,
extra_arguments=(3,),
extra_keywords={'mode': 'reflect'})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good addition!
I think apply_parallel should be mentioned before joblib. It would be also nice to have more detailed description what apply_parallel does in this case, and execution time measurements (for comparison to joblib).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thanks for review @soupault
I will do the first part.

It would be also nice to have more detailed description what apply_parallel does in this case, and execution time measurements (for comparison to joblib).

If you can explain how I can do above if would be very helpful.

@soupault soupault added this to the 0.17 milestone Oct 18, 2019
@soupault soupault self-assigned this Jan 4, 2020
@grlee77 grlee77 mentioned this pull request Aug 24, 2020
Closed
@sciunto sciunto modified the milestones: 0.17, 0.18 Sep 5, 2020
@sciunto sciunto mentioned this pull request Sep 7, 2020
Closed
Base automatically changed from master to main February 18, 2021 18:23
@mkcor mkcor mentioned this pull request Feb 22, 2021
Closed
@grlee77 grlee77 mentioned this pull request Mar 30, 2022
Open
9 tasks
@jarrodmillman jarrodmillman modified the milestones: 0.18, 0.20 Jun 4, 2022
@lagru
Copy link
Member

lagru commented Jan 21, 2023

Hey @kishan3, this seems to have been dormant for a little while. I agree with @soupault that this is a good addition. Do you have time and desire to pick this up again? Otherwise, I think this could be a decent first issue for other new contributors who may want to pick this up.

@lagru lagru removed this from the 0.20 milestone Jan 21, 2023
@lagru
Copy link
Member

lagru commented Jan 21, 2023

I've marked this as a good first issue for now. But please don't let that dissuade you if you want to continue this (I'll remove it then! 😉

@kishan3
Copy link
Author

kishan3 commented Jan 23, 2023

Hey @kishan3, this seems to have been dormant for a little while. I agree with @soupault that this is a good addition. Do you have time and desire to pick this up again? Otherwise, I think this could be a decent first issue for other new contributors who may want to pick this up.

Hey @lagru thanks for the reminder! Yes happy to release it for new contributors. 🍺

@decorouz
Copy link
Contributor

I created a PR #6837.

@lagru
Copy link
Member

lagru commented Mar 16, 2023

Closing in favor of #6837. Thanks @kishan3 for the contribution! :)

@lagru lagru closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupault soupault soupault requested changes

Assignees

@soupault soupault

Labels
🔰 Good first issue 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kishan3 @lagru @decorouz @soupault @jarrodmillman @sciunto