-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function alphanumeric_key in __all__ of io.collection.py #4321
Conversation
Frankly speaking, I am not sure if this is a good addition to the public API, since the function is rather simple and covers only quite specific naming case. Perhaps, we could have more core members to share their opinions. |
well, we wanted to use it in at least one other place, namely napari. I also don't think it warrants its own package or anything (hello left-pad), and it is complex enough that I don't want to reimplement it everywhere... But I agree that it's kinda weird to provide it. I just don't think there is a better option. |
@hmaarrfk that's pretty nice, thanks! |
Should I close this? Should we remove this function? |
I would not remove it for sure — no chance we want that dependency. The only question is whether we want it to be part of the public API. Of that I’m not sure. I suggest we wait for more devs to weigh in. |
I would be in favor to add the link to natsort in the dosctring as an indication. |
Err, woops, just left a comment on the wrong issue. Let's try again :) @jni I'd suggest renaming this function to better explain what it does, as well as moving it from io to util. |
How about |
This one is a bit tricky, maybe we should take the opportunity of a dev meeting to discuss the best name. |
As discussed in the Atlantic meeting Jan 31st, let's keep this function private and add an example with |
Cool, sounds good to me. |
Description
Fixes #4309
Test:
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x