include all md files in manifest.in #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelle
approved these changes
Jun 26, 2020
|
It is used for the sdist (at least, afaik). |
|
an easy PR to approve and merge @scikit-image/core |
alexdesiqueira
approved these changes
Jun 27, 2020
+1 @sciunto. Thank you! |
|
What is the point of having this in the source distribution? README is in there, because that is where pypi description came from. LICENSE for obvious reasons. The others? This is not where users or developers will find them. It's not a big deal either way, including a few more won't hurt. |
|
I would say that it's good having this kind of info easily available "offline" — but hey, what's offline anyway 🙂 |
|
yes, get all relevant files versioned outside git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to rationalize this file.
The CODE_OF_CONDUCT.md must be included imo.