Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: import Iterable from collections.abc (Python 3.9 compatibility) #4834

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 11, 2020

Description

This PR fixes a DeprecationWarning in the test suite related to an outdated import of Iterable. I think this will become an error starting with Python 3.9.

This warning was listed at #4454 (comment). I can take a look at some of the other ones there as well during the sprint.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

import from collections is Deprecated
@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jul 11, 2020
@alexdesiqueira alexdesiqueira merged commit c2795f0 into scikit-image:master Jul 11, 2020
@alexdesiqueira
Copy link
Member

@grlee77 thank you Greg!

@grlee77 grlee77 mentioned this pull request Jul 11, 2020
9 tasks
@grlee77 grlee77 deleted the fix_deprecation_warning branch August 19, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants