-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watershed: consider connectivity when calculating markers. #5271
Conversation
…compatible for different connectivity
…compatible for different connectivity
…compatible for different connectivity : adding test case
Hello @divyank0! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-03-14 10:12:44 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @divyank0, very clean! 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 🎉 Thanks @divyank0!
Description
here, we pass the user supplied parameter connectivity to ndi.label function instead of using default parameter value.
Changes also include the test case to cover the difference that may arise due to the change in code.
closes #5084
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.