Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watershed: consider connectivity when calculating markers. #5271

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

divyank0
Copy link
Contributor

@divyank0 divyank0 commented Mar 14, 2021

Description

here, we pass the user supplied parameter connectivity to ndi.label function instead of using default parameter value.
Changes also include the test case to cover the difference that may arise due to the change in code.

closes #5084

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

pep8speaks commented Mar 14, 2021

Hello @divyank0! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 76:80: E501 line too long (82 > 79 characters)

Line 499:62: W291 trailing whitespace
Line 518:51: E251 unexpected spaces around keyword / parameter equals
Line 518:53: E251 unexpected spaces around keyword / parameter equals
Line 518:56: E226 missing whitespace around arithmetic operator

Comment last updated at 2021-03-14 10:12:44 UTC

@rfezzani rfezzani added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Mar 15, 2021
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @divyank0, very clean! 😉

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🎉 Thanks @divyank0!

@jni jni changed the title Watershed connectivity bug: considering connectivity to calculate markers. Watershed: consider connectivity when calculating markers. Mar 16, 2021
@jni jni merged commit a69d492 into scikit-image:main Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
4 participants