channel_as_last_axis decorator fix #5348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After moving the channel axis to the last position,
channel_as_last_axis
also needs to update thechannel_axis
kwarg to -1.This bug was not revealed by the existing test cases for functions where it was used because these functions seem to only check that
channel_axis is not None
. See for example:scikit-image/skimage/exposure/histogram_matching.py
Line 66 in 044ac80
The new test here verifies both that the data has been reshaped and the argument set to -1 as expected.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.