Add stitching gallery example

[rfezzani]

Description

This gallery example is a show case for the stitching problem using skimage. It is based on my answer to a question in image.sc forum and its related issue #5330.

I used the moon image to simulate a set of noisy and tilted images:

And here is the obtained composite image:

I will appreciate any help for rephrasing and clarifying the comments 😉.

Checklist

• Docstrings for all functions
• Gallery example in ./doc/examples (new features only)
• Benchmark in ./benchmarks, if your changes aren't covered by an
  existing benchmark
• Unit tests
• Clean style in the spirit of PEP8

For reviewers

• Check that the PR title is short, concise, and will make sense 1 year
  later.
• Check that new functions are imported in corresponding __init__.py.
• Check that new features, API changes, and deprecations are mentioned in
  doc/release/release_dev.rst.

[pep8speaks]

Hello @rfezzani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file doc/examples/registration/plot_stitching.py:

Line 94:16: E126 continuation line over-indented for hanging indent

Comment last updated at 2021-09-03 07:34:33 UTC

[alexdesiqueira]

Looks awesome @rfezzani, thank you for this! I'm just leaving some comments on consistency.

[rfezzani]

Thank you @alexdesiqueira for your review 😉

[grlee77]

Thanks, this is a nice addition. I have requested a number of small edits to the text

[rfezzani]

thank you @grlee77 for your review 😉

[lagru]

Looks good so far! I didn't look to deep yet so I only found nitpicks and maybe a small oversight regarding the noise generation.

[rfezzani]

Thank you @lagru for your review 😉

[rfezzani]

Thank you @mkcor for your review 😉 . Do you request any other change @grlee77?

[mkcor]

Thank you @mkcor for your review wink . Do you request any other change @grlee77?

You're welcome, @rfezzani! I have two qualitative suggestions to add:

• I prefer titles at the imperative ("Adjust gamma and log contrast" rather than "Gamma and log contrast adjustment") because they are more engaging and they make it clear the reader is embarking on a tutorial; I'm well aware that, as of today, the gallery isn't standardized in this respect, but I've been pushing in this direction whenever a new tutorial-like example was submitted;
• I find it's more pedagogic to import submodules rather than functions directly, so that when the reader runs or reads the code, they see feature.corner_harris, filters.gaussian, etc. and they think "Gaussian is a filter indeed" and, indirectly, they learn the codebase organization and, also, the import header is then more compact.

[mkcor]

PS: @rfezzani did you know you could apply suggested changes as a batch? https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

[rfezzani]

PS: @rfezzani did you know you could apply suggested changes as a batch? https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

Nop, I didn't 🙂 thank you for the tip...

[rfezzani]

@mkcor, I implemented submodules imports instead of functions import as you suggested. If you have any idea for an imperative title I would be happy to modify the actual title 😉.

[mkcor]

@mkcor, I implemented submodules imports instead of functions import as you suggested. If you have any idea for an imperative title I would be happy to modify the actual title wink.

Wonderful! I would say "Reconstruct images with simple image stitching" or maybe "Recompose images ..." (likewise, I would suggest "Reconstruct an image with inpainting" here https://scikit-image.org/docs/stable/auto_examples/filters/plot_inpaint.html).

[rfezzani]

@mkcor, I modified the title to Assemble images with simple image stitching, is it OK for you?

[grlee77]

Looks good to me. I just left one (optional) suggestion related to variable names.

[mkcor]

Thank you for your patience, @rfezzani! I left two suggestions to include hyperlinks, but if they are confusing for now, I can merge today and we can dig deeper another time.

[mkcor]

Suggested change

	# **Robust matching using Ransac** gallery example, but any other
	# :ref:`sphx_glr_auto_examples_transform_plot_matching.py` gallery example, but any other

[mkcor]

Here I'm not sure how the Sphinx link to the #image-registration anchor should be done... Maybe

Suggested change

	# method from the **Image registration** section can be applied,
	# method from the :ref:`sphx_glr_auto_examples_registration` section can be applied,

?

[rfezzani]

I confess that I don't really know how to properly manage Sphinx hyperlinks (that's why I didn't included them 😅)

[mkcor]

All good, I'll take a look locally when I get a chance!

[rfezzani]

🎉 Thank you all for your help and review @alexdesiqueira @grlee77 @lagru @mkcor

[alexdesiqueira]

Thank you @rfezzani!