Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort configuration to pyproject.toml #5524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 21, 2021

Description

This PR adds an isort configuration to pyproject.toml. To avoid introducing conflicts, I have not run isort with this configuration on the code base. It can be used by devs to manually update specific, individual files in new PRs (e.g. isort <filename>). Without this configuration, it is hard to remember the command line options and apply them consistently.

In the future, we could potentially configure something with pre-commit to automatically apply this to any modified files.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

This file is recommended over setup.cfg in the isort documentation

add supported_extensions so Cython extensions are also included
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Aug 21, 2021
grlee77 added a commit to robinthibaut/scikit-image that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant