Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize moments tests #6323

Merged
merged 1 commit into from Apr 8, 2022
Merged

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 7, 2022

Description

This is a small followup to #6296 by @tibuch, that just parametrizes moments tests to reduce code duplication.

I did make one minor change to add image intensity scaling in test_moments_coords as well.

Imports have been sorted following the style proposed in #5524

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Apr 7, 2022
@alexdesiqueira
Copy link
Member

LGTM! Thanks @grlee77!

@jni jni merged commit dcdfa63 into scikit-image:main Apr 8, 2022
alexdesiqueira pushed a commit to alexdesiqueira/scikit-image that referenced this pull request May 24, 2022
@lagru lagru added this to the 0.20 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants