Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user warning message for viewer module. #6133

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Dec 16, 2021

Description

As per #6119 (comment)

Reference: https://github.com/scikit-image/scikit-image/discussions/5651#discussioncomment-1596365

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@mkcor
Copy link
Member Author

mkcor commented Dec 16, 2021

And I guess all TODO's in this module could/should be converted into WON'TDO's?

mkcor@[...]scikit-image/skimage/viewer$ ack TODO
utils/dialogs.py
31:    # TODO: io plugins should assign default image formats

plugins/overlayplugin.py
39:        #TODO: `color` doesn't update GUI widget when set manually.

plugins/plotplugin.py
49:        #TODO: Converted color is slightly different than Qt background.

plugins/base.py
68:    #TODO: Add flag so image is not passed to filter function by default.
123:        #TODO: Always passing image as first argument may be bad assumption.

widgets/history.py
89:            # TODO: This check/conversion should probably be in `imsave`.

viewers/core.py
103:        # TODO: Add ImageViewer to skimage.io window manager
376:        # TODO: Adjust height to accommodate slider; the following doesn't work

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Dec 19, 2021
@hmaarrfk hmaarrfk merged commit d52c11d into scikit-image:main Dec 27, 2021
@hmaarrfk
Copy link
Member

hmaarrfk commented Jan 5, 2022

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Jan 5, 2022
hmaarrfk added a commit that referenced this pull request Jan 5, 2022
…3-on-v0.19.x

Backport PR #6133 on branch v0.19.x (Update user warning message for viewer module.)
@lagru lagru added this to the 0.19.2 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants