Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports/refs from deprecated scipy.ndimage.filters namespace #6231

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

larrybradley
Copy link
Contributor

Description

scipy 1.8.0 deprecated the scipy.ndimage.filters namespace. This PR updates the import for scipy.ndimage.laplace and the doc reference to scipy.ndimage.generate_binary_structure.

These changes should work fine with older scipy versions (but I don't see a minimum scipy dependency for this package). For example, the scipy.ndimage.generate_binary_structure reference is currently used in other places in skimage.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@larrybradley
Copy link
Contributor Author

The AppVeyor CI failure is unrelated.

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larrybradley! This will work for all supported SciPy versions (current requirement is >=1.4.1)

@grlee77 grlee77 added this to the 0.19.2 milestone Feb 8, 2022
@grlee77 grlee77 merged commit c295090 into scikit-image:main Feb 8, 2022
@grlee77
Copy link
Contributor

grlee77 commented Feb 8, 2022

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Feb 8, 2022
grlee77 added a commit that referenced this pull request Feb 8, 2022
…1-on-v0.19.x

Backport PR #6231 on branch v0.19.x (Update imports/refs from deprecated scipy.ndimage.filters namespace)
@larrybradley larrybradley deleted the scipy-laplace branch February 8, 2022 01:12
@lagru lagru added backport: 0.19.x 🔧 type: Maintenance Refactoring and maintenance of internals labels Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants