Support array-likes consistently in geometric transforms #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray-like inputs As-is some transform types support array-like inputs, but most did not resolves scikit-imagegh-4383
grlee77
added
⏩ type: Enhancement
rfezzani
approved these changes
Mar 1, 2022
mkcor
reviewed
Mar 4, 2022
| @@ -245,11 +246,21 @@ def test_fundamental_matrix_residuals(): | |||
| assert_almost_equal(tform.residuals(src, dst)**2, [0, 0.5, 2]) | |||
|
|
|||
|
|
|||
| def test_fundamental_matrix_forward(): | |||
| @pytest.mark.parametrize('array_like_input', [False, True]) | |||
There was a problem hiding this comment.
A bit confusing for me at first read, because an array is a fortiori array-like... 🙃
But I admit that not_array_but_array_like_input would be too long!
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
|
Thank you @grlee77! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4383
As-is some transform types support array-like inputs (e.g. the
translationargument toAffineTransform), but most did not. This PR attempts to make all__call__,inverse,__init__andestimatecalls support array-like inputs. A number of test cases were parametrized to test with list-of-list inputs formatrix,paramsandsrc/dstcoordinates.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.