hough_line_peaks fix for corner case with optimal angle=0 #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
🩹 type: Bug fix
|
Hello @grlee77! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
grlee77
commented
Feb 28, 2022
| @@ -63,7 +62,7 @@ def hough_line_peaks(hspace, angles, dists, min_distance=9, min_angle=10, | |||
| min_ydistance=min_distance, | |||
| threshold=threshold, | |||
| num_peaks=num_peaks) | |||
| if a.any(): | |||
| if a.size > 0: | |||
There was a problem hiding this comment.
This is the line fixes the bug. the other modified lines are flake8/isort fixes and the new test case
grlee77
changed the title
rfezzani
approved these changes
Mar 1, 2022
| @@ -63,7 +62,7 @@ def hough_line_peaks(hspace, angles, dists, min_distance=9, min_angle=10, | |||
| min_ydistance=min_distance, | |||
| threshold=threshold, | |||
| num_peaks=num_peaks) | |||
| if a.any(): | |||
| if a.size > 0: | |||
|
@meeseeksdev backport to v0.19.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/scikit-image
that referenced
this pull request
Apr 1, 2022
…ith optimal angle=0
grlee77
added a commit
that referenced
this pull request
Apr 1, 2022
…1-on-v0.19.x Backport PR #6271 on branch v0.19.x (hough_line_peaks fix for corner case with optimal angle=0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4129, #6187
An array,
awith a single element equal to zero is possible and is not handled properly inhough_line_peaks. This PR fixes that and adds a test case based on the example from #6187.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.