remove extraneous function in createluts.py (and move mc_meta reference code) #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids flake8 warning about undefined variable
update comment at top of _marching_cubes_lewiner_luts.py
grlee77
changed the title
mkcor
approved these changes
Mar 21, 2022
|
Merging as I guess the doc timeout is unrelated. Thanks to both of you. Unless I'm missing something, I don't think this PR should close the original issue #4163 as only one of the undefined variables is addressed. is still found by flake8. |
|
See #6307. In retrospect, I could probably have pushed that change here. |
alexdesiqueira
pushed a commit
to alexdesiqueira/scikit-image
that referenced
this pull request
May 24, 2022
…ce code) (scikit-image#6294) * remove extraneous function in createluts.py avoids flake8 warning about undefined variable * move mc_meta reference script out of the skimage namespace update comment at top of _marching_cubes_lewiner_luts.py * skip of mc_meta/visual_test.py no longer needed in conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first commit avoids the
flake8warning about an undefined variablelutsreported inmc_meta/createluts.py(see #4163).The remaining commits move the whole
mc_metafolder out of theskimagepackage path so that it will not be distributed with scikit-image. It appears to just be there for developer reference and is not otherwise used. I chose to place it intools/precomputewhich is the path used for scripts precomputing attributes for the moments computations in #6188 as well as for the proposed morphology decompositions in #6150. I think it is nice to have the scripts for cases like these available in the repository for developer reference, but they do not need to be distributed to end users.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.