-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for error in 'Using Polar and Log-Polar Transformations for Registration' (#6304) #6306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mellertd
@meeseeksdev backport to v0.19.x |
…Polar Transformations for Registration' (scikit-image#6304)
What a cool bot is that? |
https://github.com/MeeseeksBox/MeeseeksDev/ by @Carreau. It's so good. ❤️ |
@blink1073 has done most of the recent updates, so as many kudoes go to him. |
Description
Bug fix to close #6304. The addition of the
normalization
parameter that defaults to "phase" in thephase_cross_correlation
function changed the result in the example to be incorrect. I still don't fully understand why this happened, but across all examples in this particular gallery example, settingnormalization
toNone
causes small to significant improvements to the performance of the approach. I think this is worth further investigation, but not enough to hold up this fix.Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.