Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error in 'Using Polar and Log-Polar Transformations for Registration' (#6304) #6306

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

mellertd
Copy link
Contributor

Description

Bug fix to close #6304. The addition of the normalization parameter that defaults to "phase" in the phase_cross_correlation function changed the result in the example to be incorrect. I still don't fully understand why this happened, but across all examples in this particular gallery example, setting normalization to None causes small to significant improvements to the performance of the approach. I think this is worth further investigation, but not enough to hold up this fix.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that did the trick. To compare: 0.18.x, 0.19.x, this PR

0.18.x and this PR seem almost identical. However the "Recovered value for scaling difference" in Part 1 is close but still not the same. But this does not change the qualitative statement of the example.

Thanks @mellertd!

@lagru lagru added action: mrg+1 🩹 type: Bug fix Fixes unexpected or incorrect behavior 📄 type: Documentation Updates, fixes and additions to documentation labels Mar 29, 2022
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mellertd

@grlee77 grlee77 merged commit 5a57688 into scikit-image:main Apr 1, 2022
@grlee77
Copy link
Contributor

grlee77 commented Apr 1, 2022

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Apr 1, 2022
grlee77 added a commit that referenced this pull request Apr 1, 2022
…6-on-v0.19.x

Backport PR #6306 on branch v0.19.x (Fix for error in 'Using Polar and Log-Polar Transformations for Registration' (#6304))
@VolkerH
Copy link
Contributor

VolkerH commented Apr 1, 2022

@meeseeksdev backport to v0.19.x

What a cool bot is that?

@jni
Copy link
Member

jni commented Apr 2, 2022

https://github.com/MeeseeksBox/MeeseeksDev/ by @Carreau. It's so good. ❤️

@Carreau
Copy link
Contributor

Carreau commented Apr 2, 2022

@blink1073 has done most of the recent updates, so as many kudoes go to him.
You can see some stats about what the bot does here: https://meeseeksbox.github.io/

@lagru lagru added this to the 0.19.3 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery example 'Using Polar and Log-Polar Transformations for Registration' needs fixing
6 participants