Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by pinning to Pillow!=9.1.0 #6315

Merged
merged 2 commits into from Apr 4, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 1, 2022

Description

closes #6314

Some grayscale image I/O via imageio was broken with the 9.1.0 release of Pillow
see: #6314

This PR pins to <9.1 so CI runs will pass.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

Some grayscale image I/O via imageio is broken with the 9.1.0 release of Pillow
see: scikit-image#6314
@grlee77 grlee77 added 🔧 type: Maintenance Refactoring and maintenance of internals 🩹 type: Bug fix Fixes unexpected or incorrect behavior labels Apr 1, 2022
requirements/default.txt Outdated Show resolved Hide resolved
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@grlee77 grlee77 merged commit 16f3e78 into scikit-image:main Apr 4, 2022
@grlee77 grlee77 changed the title Fix CI by pinning to Pillow<9.1.0 Fix CI by pinning to Pillow!=9.1.0 Apr 4, 2022
@lagru lagru added this to the 0.20 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pillow 9.1 breaks a few test cases
4 participants