avoid warnings about change to v3 API from imageio #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try importing imread, imsave directly from imageio.v2 when available
grlee77
added
🔧 type: Maintenance
|
Looks like this is working as expected (The |
alexdesiqueira
approved these changes
Apr 14, 2022
jni
approved these changes
Apr 15, 2022
|
@meeseeksdev backport to v0.19.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/scikit-image
that referenced
this pull request
Apr 15, 2022
grlee77
added a commit
that referenced
this pull request
Apr 15, 2022
…3-on-v0.19.x Backport PR #6343 on branch v0.19.x (avoid warnings about change to v3 API from imageio)
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Apr 18, 2022
because scikit-image fixed it in scikit-image/scikit-image#6343
9 tasks
|
Hello and thanks for this fix! May I know which release will have this? |
|
I can release a 0.19.3 release in the next week or so. |
alexdesiqueira
pushed a commit
to alexdesiqueira/scikit-image
that referenced
this pull request
May 24, 2022
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Jun 13, 2022
because scikit-image fixed it in scikit-image/scikit-image#6343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6341
This PR imports
imread,imsavedirectly fromimageio.v2when available to avoid a warning that has been causing recent CI failures. This also ensures there will not be an unexpected change in behavior to existing code once imagio's default changes to the v3 API. We can migrate to that API version at a later time.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.