No valueerror for underdetermined #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analog classes to LineModelND do not raise a ValueError when inputs are under determined but instead return False. Please see issue #6452, Proposed changes 1 and 2. This commit also removes redundancies in test_fit.py.
Analog classes to CircleModel do not raise a ValueError when inputs are under determined but instead return False. Please see issue #6452, Proposed changes 3 and 4.
|
Hello @judafe! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-08-26 22:00:51 UTC |
rfezzani
added
🔧 type: Maintenance
|
Thanks @judafe, good to see you back here. I wouldn't worry about those warnings. I had been meaning to fix the I/O ones for awhile, so this was a good motivation to go ahead and do it (see #6460) |
mkcor
reviewed
Aug 23, 2022
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
mkcor
approved these changes
Aug 23, 2022
|
CI is failing for ImportError: "<function show_rag at 0x7fe5b0767160>" in "skimage.future.graph.rag" requires "matplotlib >=3.5"although scikit-image/skimage/future/graph/rag.py Line 449 in c129f02 |
ImportError: "<function show_rag at 0x7fe5b0767160>" in "skimage.future.graph.rag" requires "matplotlib >=3.5"@mkcor, |
|
Thanks, @judafe! I guess I didn't refresh my page 🙃 |
lagru
added a commit
to lagru/scikit-image
that referenced
this pull request
Oct 29, 2022
Instead of raising a ValueError, since f8dfea6 [1] this is addressed by returning `False`. [1] scikit-image#6453
grlee77
added a commit
that referenced
this pull request
Nov 30, 2022
* Complete deprecation of selem parameter in favor of footprint. Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of selem module Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of in_place parameter in favor of "out". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of max_iterations parameter in favor of "max_num_iter". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of max_iter parameter in favor of "max_num_iter". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of iterations parameter in favor of "num_iter". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of n_iter_max parameter in favor of "max_num_iter". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of compute_hessian_eigenvalues Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of input parameter in favor of "label_image". Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of greyco* functions Though removed_version points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Complete deprecation of multichannel kwarg Though the default removed_version of deprecate_multichannel_kwarg points at 1.0, the deprecation is finished in 0.20 which was not planned at the time of 0.19's release. * Remove unused deprecate_multichannel_kwarg This decorator is no longer necessary since the deprecation of multichannel is completed with 0.20 (previously 1.0). Make test's independent of temporary decorations of library functions such as hog and pyramid_gaussian. Their deprecation decorator was removed. * Complete deprecation of height, width in rectangle and remove unused imports. * Remove completed items in TODO.txt For filters.inverse(), the removed_version targets 0.21 and not 0.20. So move. * Complete deprecation of neighbourhood parameter I think removed_version="1.2" is actually supposed to be 1.0 (or 0.20). * Remove deprecated grey and greyreconstruct modules These deprecations are already part of 0.19. So it should be fine to remove them in 0.20. * Remove warning about deprecated *_iter Missed this earlier. * Revert "Complete deprecation of compute_hessian_eigenvalues" This reverts commit 56f0431. The deprecation of `compute_hessian_eigenvalues` was introduced after all 0.19.x releases (see git tag --contains d2689f5)! So the target should be 0.21. * Deprecate automatic channel detection in gaussian Automatic detection of the color channel based on the old deprecated `multichannel=None` was broken in version 0.19. This commit recovers the old behavior for 0.20 using a proxy object `ChannelAxisNotSet`. The behavior is still deprecated though and should be removed completely in 0.21. Note that the warning is only raised if the automatic behavior deviates from the behavior that will be the new default in 0.21, which is `channel_axis=None`. This way we only notify users that were affected by the broken behavior in 0.19 and now deprecated behavior in 0.20. * Complete deprecation of coordinates parameter in `regionprops` (since 0.16) and `active_contour` (since 0.18). * Remove outdated TODO for CircleModel.estimate Instead of raising a ValueError, since f8dfea6 [1] this is addressed by returning `False`. [1] #6453 * Remove removed files from meson.build These were removed in d951774 and b53b46a. * Remove obsolete tests for coordinates parameter * Catch expected warning for deprecated color channel inference in gaussian * Update skimage/_shared/filters.py Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com> * Explain proxy value in more clearly Co-authored-by: Gregory Lee <grlee77@gmail.com> Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If accepted, this PR closes #6452.
Checklist
./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.
Tests