New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use context manager when possible #6484
Use context manager when possible #6484
Conversation
Hello @rfezzani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-08-24 09:39:20 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rfezzani for completing this obvious improvement. May I suggest two more candidates:
- https://github.com/scikit-image/scikit-image/blob/main/doc/source/random_gallery.py#L52-L54
- https://github.com/scikit-image/scikit-image/blob/main/doc/tools/apigen.py#L182-L184
I don't think these are covered by #6458 which I don't want to hold up further.
Otherwise looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my suggestions. Looks ready to merge in my opinion. But perhaps we should wait until #6458 is merged to avoid merge conflicts for that first-time contribution..
Thank you @lagru. |
Fantastic, thank you @rfezzani ! |
Thank you @rfezzani! |
Description
Completes #6458 refactoring.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.