Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify header pointing to notes for latest version released. #6508

Merged
merged 1 commit into from Sep 21, 2022

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Sep 8, 2022

Description

Minor / docs (one core dev approval is enough)
Related to #6496

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

This header points to the release notes for the latest version.
@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Sep 8, 2022
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkcor, this is an improvement so merging. But I don't think it fixes #6496 which I understand to be about the incongruence between "0.20.0.dev0" in the sidebar and "We’re happy to announce the release of scikit-image v0.19.3!" in the first line after the modified heading.

@lagru lagru merged commit b06a784 into main Sep 21, 2022
@lagru lagru deleted the point-latest-release branch September 21, 2022 10:12
@lagru
Copy link
Member

lagru commented Sep 21, 2022

@mkcor I just noticed that you used a branch on our main repo, was that intentional?

@lagru lagru restored the point-latest-release branch September 21, 2022 10:13
@mkcor mkcor deleted the point-latest-release branch September 21, 2022 17:27
@mkcor
Copy link
Member Author

mkcor commented Sep 21, 2022

@mkcor I just noticed that you used a branch on our main repo, was that intentional?

No, it wasn't. My bad. I didn't pay attention to this when editing from the GitHub interface.

But I don't think it fixes #6496

Right, that's why I wrote "related to" (not "fixes" or "closes").

@lagru
Copy link
Member

lagru commented Sep 21, 2022

No worries. But look at the edit, you wrote "closes". 😁

@mkcor
Copy link
Member Author

mkcor commented Sep 21, 2022

No worries. But look at the edit, you wrote "closes". 😁

Oh, you edited! 😆 Sorry, I didn't (try to) remember. It's my first time using GitHub's version control for comments; I had never noticed this was available just like any other history; thanks for drawing my attention to it! 🙏

@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants