New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml for Python 3.11 support and to fix 32-bit Windows pinnings #6519
Conversation
This will be more robust against potentially breaking future setuptools changes
changes here are consistent with upstream SciPy and PyWavelets
…lotlib 3.11 wheels can be found NumPy and PyWavelets already have 3.11 support on PyPI
This is for robustness against potential future breaking changes. For example, 65.0 broke in-place builds (i.e. using )
…y broken cache on CircleCI
Thanks @jarrodmillman for adding the Python 3.11 tests in #6566. I think there are still some
Note that the setuptools pin is only for the version used during the build and is not a restriction on users installing scikit-image. |
@jarrodmillman shouldn't we request your review of this PR, in the perspective of the 0.20 release? ❤️ |
I am going to merge this and rebase PR #6581 on it. |
Thank you, @jarrodmillman! |
Update
This PR has been revised to only make some minor updates to pyproject.toml as the 3.11 testing on CI was since added separately in #6566. The original description is still below
Description
This PR adds a test case with Python "3.11-dev" (currently 3.11.0-rc.2) to the linux and MacOS test matrices. For now, extra pip flags are added to help find nightly 3.11 wheels for SciPy and Matplotlib. NumPy, Cython and PyWavelets have Python 3.11 wheels up on PyPI itself.
Aside from the 3.11-specific changes there are two additional improvements to
pyproject.toml
here:win32
wheels that are currently skipped on 3.10 in our wheel building scriptChecklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.